lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Jan 2016 14:31:02 +0100 From: David Sterba <dsterba@...e.cz> To: Dan Carpenter <dan.carpenter@...cle.com> Cc: Chris Mason <clm@...com>, Liu Bo <bo.li.liu@...cle.com>, Josef Bacik <jbacik@...com>, David Sterba <dsterba@...e.com>, linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [patch] Btrfs: clean up an error code in btrfs_init_space_info() On Wed, Jan 13, 2016 at 03:21:17PM +0300, Dan Carpenter wrote: > If we return 1 here, then the caller treats it as an error and returns > -EINVAL. It causes a static checker warning to treat positive returns > as an error. > > Fixes: 1aba86d67f34 ('Btrfs: fix easily get into ENOSPC in mixed case') > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> > --- > I would appreciate a little review here. This patch doesn't change > behavior, but it's possible that we had intended to do something else. No, it makes sense to switch it to -EINVAL. Thanks. Reviewed-by: David Sterba <dsterba@...e.com>
Powered by blists - more mailing lists