linux-kernel - Re: [PATCH v2 1/1] net: netlink: Fix multicast group storage allocation for families with more than one groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160113.102735.1851782053420522112.davem@davemloft.net>
Date:	Wed, 13 Jan 2016 10:27:35 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	matti.vaittinen@...ia.com
Cc:	johannes.berg@...el.com, jbenc@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, alexander.sverdlin@...ia.com,
	teppo.o.pennanen@...ia.com
Subject: Re: [PATCH v2 1/1] net: netlink: Fix multicast group storage
 allocation for families with more than one groups

From: Matti Vaittinen <matti.vaittinen@...ia.com>
Date: Wed, 13 Jan 2016 09:54:12 +0200

> Hello again,
> 
>       Second version, Fixed the 'off by one' bug spotted by David.
> 
>       Br.
>         Matti Vaittinen
> 
> Multicast groups are stored in global buffer. Check for needed buffer size
> incorrectly compares buffer size to first id for family. This means that
> for families with more than one mcast id one may allocate too small buffer
> and end up writing rest of the groups to some unallocated memory. Fix the
> buffer size check to compare allocated space to last mcast id for the
> family.
> 
> Tested on ARM using kernel 3.14
> 
> Signed-off-by: Matti Vaittinen <matti.vaittinen@...ia.com>

I inadvertantly applied your original patch, so I'll just fix
the off-by-one error with a seperate commit.

Sorry for the confusion and thanks for fixing this.