linux-kernel - Re: [PATCH v5 7/7] sparc64: mm/gup: add gup trace points

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <569693B4.6060305@linaro.org>
Date:	Wed, 13 Jan 2016 10:13:08 -0800
From:	"Shi, Yang" <yang.shi@...aro.org>
To:	akpm@...ux-foundation.org, rostedt@...dmis.org, mingo@...hat.com
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	linaro-kernel@...ts.linaro.org,
	"David S. Miller" <davem@...emloft.net>, sparclinux@...r.kernel.org
Subject: Re: [PATCH v5 7/7] sparc64: mm/gup: add gup trace points

Hi David,

Any comment on this one? The tracing part review has been done.

Thanks,
Yang


On 12/9/2015 1:22 PM, Yang Shi wrote:
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: sparclinux@...r.kernel.org
> Signed-off-by: Yang Shi <yang.shi@...aro.org>
> ---
>   arch/sparc/mm/gup.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/arch/sparc/mm/gup.c b/arch/sparc/mm/gup.c
> index 2e5c4fc..5a06c34 100644
> --- a/arch/sparc/mm/gup.c
> +++ b/arch/sparc/mm/gup.c
> @@ -12,6 +12,8 @@
>   #include <linux/rwsem.h>
>   #include <asm/pgtable.h>
>
> +#include <trace/events/gup.h>
> +
>   /*
>    * The performance critical leaf functions are made noinline otherwise gcc
>    * inlines everything into a single function which results in too much
> @@ -174,6 +176,8 @@ int __get_user_pages_fast(unsigned long start, int nr_pages, int write,
>   	len = (unsigned long) nr_pages << PAGE_SHIFT;
>   	end = start + len;
>
> +	trace_gup_get_user_pages_fast(start, nr_pages);
> +
>   	local_irq_save(flags);
>   	pgdp = pgd_offset(mm, addr);
>   	do {
> @@ -236,6 +240,8 @@ int get_user_pages_fast(unsigned long start, int nr_pages, int write,
>
>   	local_irq_enable();
>
> +	trace_gup_get_user_pages_fast(start, nr_pages);
> +
>   	VM_BUG_ON(nr != (end - start) >> PAGE_SHIFT);
>   	return nr;
>
>