linux-kernel - Re: Nokia N900: u-SD card in v4.2+

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160113192007.GK12777@atomide.com>
Date:	Wed, 13 Jan 2016 11:20:08 -0800
From:	Tony Lindgren <tony@...mide.com>
To:	Pavel Machek <pavel@....cz>
Cc:	Kishon Vijay Abraham I <kishon@...com>,
	Pali Rohár <pali.rohar@...il.com>,
	sre@...ian.org, sre@...g0.de,
	kernel list <linux-kernel@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	linux-omap@...r.kernel.org, khilman@...nel.org,
	aaro.koskinen@....fi, ivo.g.dimitrov.75@...il.com,
	patrikbachan@...il.com
Subject: Re: Nokia N900: u-SD card in v4.2+

* Pavel Machek <pavel@....cz> [160113 11:13]:
> On Mon 2016-01-11 14:10:23, Kishon Vijay Abraham I wrote:
> > 
> > 'select' is generally not recommended since it selects a config without
> > caring for the dependency. With adding 'depends on', MMC won't be enabled and
> > will end up in the same problem.
> 
> Well... it really should "depend on". Not ideal, but you'll likely
> realize what went on.
> 
> Silently compiling known-bad kernel is ... well.. bad.

Force selects will lead into build errors sooner or later.

> > Tony has already added a Documentation noting that CONFIG_REGULATOR_PBIAS
> > should be enabled for MMCs to work.
> > commit d8e1f5ed11a39a68da00f05000466c4f6db4456e
> > Author: Tony Lindgren <tony@...mide.com>
> > Date:   Mon Oct 12 16:19:54 2015 -0700
> > 
> >     Documentation: ARM: List new omap MMC requirements
> > 
> > Maybe we should also make the error message a little more verbose to tell the
> > user that CONFIG_REGULATOR_PBIAS be selected?
> 
> That would help.
> 
> As would #error if we recognize broken config.

Can't we just add a check to the omap_hsmmc.c? In cases where
MMC1 has the PBIAS regulator configured but not available, print
an error about missing CONFIG_REGULATOR_PBIAS error and return
-EPROBE_DEFER?

Regards,

Tony