linux-kernel - Re: [lkp] [string_helpers] 26cfdc920f: kmsg.test_string_helpers:string_get_size(size=#,blk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87lh7s4j0j.fsf@vitty.brq.redhat.com>
Date:	Thu, 14 Jan 2016 10:17:48 +0100
From:	Vitaly Kuznetsov <vkuznets@...hat.com>
To:	LKML <linux-kernel@...r.kernel.org>
Cc:	James Bottomley <JBottomley@...n.com>, lkp@...org,
	kernel test robot <ying.huang@...ux.intel.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [lkp] [string_helpers] 26cfdc920f: kmsg.test_string_helpers:string_get_size(size=#,blk_size=#,units=

kernel test robot <ying.huang@...ux.intel.com> writes:

> FYI, we noticed the below changes on
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> commit 26cfdc920f1bb5766ff1493712a4f5a97ee5e484 ("string_helpers: fix precision loss for some inputs")
>
> [    1.775834] test_string_helpers: Running tests...
> [    1.775834] test_string_helpers: Running tests...
> [    1.776987] test_string_helpers: Test 'test_string_get_size_one' failed!
> [    1.776987] test_string_helpers: Test 'test_string_get_size_one' failed!
> [    1.778265] test_string_helpers: string_get_size(size = 8192, blk_size = 4096, units = 0
> [    1.778265] test_string_helpers: string_get_size(size = 8192, blk_size = 4096, units = 0
> [    1.779732] test_string_helpers: expected: '32.7 MB', got '33.6 MB'
> [    1.779732] test_string_helpers: expected: '32.7 MB', got '33.6 MB'

Yes, there was a patch updating tests in my series but apparently James's
solution got merged without it. I'll dig it out and send.

-- 
  Vitaly