linux-kernel - Re: [PATCH v6 12/15] tty: serial: 8250: Correct conversion specifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 14 Jan 2016 11:31:24 +0200
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Anton Wuerfel <anton.wuerfel@....de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Jiri Slaby <jslaby@...e.com>,
	"James E.J. Bottomley" <jejb@...isc-linux.org>,
	Helge Deller <deller@....de>,
	Joachim Eastwood <manabian@...il.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	Masahiro Yamada <yamada.masahiro@...ionext.com>,
	Peter Hurley <peter@...leysoftware.com>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Phillip Raffeck <phillip.raffeck@....de>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Peter Hung <hpeter@...il.com>, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-parisc@...r.kernel.org,
	linux-kernel <linux-kernel@...cs.fau.de>
Subject: Re: [PATCH v6 12/15] tty: serial: 8250: Correct conversion
 specifiers

On Wed, 2016-01-13 at 22:29 +0100, Anton Wuerfel wrote:
> This patch fixes compiler warnings about wrong conversion specifiers 

This patch obviously doesn't _fix_warnings_, rather changes specifiers
to get it consistent with argument.

> used
> in a debug output in 8250_pnp.c. The precise warning is:

Usually there is no need to cite all lines…

> 
> drivers/tty/serial/8250/8250_pnp.c: In function ‘serial_pnp_probe’:
> include/linux/dynamic_debug.h:64:16: warning: format ‘%x’ expects
> argument
> of [...]

OK.

> 
> include/linux/dynamic_debug.h:84:2: note: in expansion of macro
> ‘DEFINE_DYNAMIC_DEBUG_METADATA’
> 
> include/linux/device.h:1179:2: note: in expansion of macro
> ‘dynamic_dev_dbg’

Redundant.

> 
> drivers/tty/serial/8250/8250_pnp.c:467:2: note: in expansion of macro
> ‘dev_dbg’
>   dev_dbg(&dev->dev,
>   ^
> include/linux/dynamic_debug.h:64:16: warning: format ‘%lx’ expects
> argument
> of [...]

OK.

> 
> include/linux/dynamic_debug.h:84:2: note: in expansion of macro
> ‘DEFINE_DYNAMIC_DEBUG_METADATA’
> 
> include/linux/device.h:1179:2: note: in expansion of macro
> ‘dynamic_dev_dbg’

Redundant.

> 
> drivers/tty/serial/8250/8250_pnp.c:467:2: note: in expansion of macro
> ‘dev_dbg’
>   dev_dbg(&dev->dev,
>   ^
> 
> Those warnings never got triggered, because the command was nested
> in an #ifdef, which is removed by a patch of this series.
> 
> Signed-off-by: Anton Würfel <anton.wuerfel@....de>
> Signed-off-by: Phillip Raffeck <phillip.raffeck@....de>
> Cc: linux-kernel@...cs.fau.de
> ---
>  drivers/tty/serial/8250/8250_pnp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_pnp.c
> b/drivers/tty/serial/8250/8250_pnp.c
> index 0c32c59..92f4412 100644
> --- a/drivers/tty/serial/8250/8250_pnp.c
> +++ b/drivers/tty/serial/8250/8250_pnp.c
> @@ -465,8 +465,8 @@ serial_pnp_probe(struct pnp_dev *dev, const
> struct pnp_device_id *dev_id)
>  		return -ENODEV;
>  
>  	dev_dbg(&dev->dev,
> -		 "Setup PNP port: port %x, mem 0x%lx, irq %d, type
> %d\n",
> -		 uart.port.iobase, uart.port.mapbase,
> +		 "Setup PNP port: port %lx, mem 0x%lx, irq %d, type
> %d\n",
> +		 uart.port.iobase, (unsigned long)uart.port.mapbase,

This approach is not fully correct. In Linux kernel we have %p
extensions to cover some custom types such as resource_size_t, of which
mapbase is.

Thus,

"Setup PNP port: port %lx, mem %pa, irq %d, type %d\n",
uart.port.iobase, &uart.port.mapbase,

looks better.

>  		 uart.port.irq, uart.port.iotype);
>  
>  	if (flags & CIR_PORT) {

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy