linux-kernel - Re: [PATCH 3/9] perf build: Test correct path of perf in build-test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <569774EA.30008@huawei.com>
Date:	Thu, 14 Jan 2016 18:14:02 +0800
From:	"Wangnan (F)" <wangnan0@...wei.com>
To:	Jiri Olsa <jolsa@...hat.com>
CC:	<acme@...nel.org>, <linux-kernel@...r.kernel.org>,
	<pi3orama@....com>, <lizefan@...wei.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH 3/9] perf build: Test correct path of perf in build-test



On 2016/1/14 18:04, Jiri Olsa wrote:
> On Wed, Jan 13, 2016 at 12:17:16PM +0000, Wang Nan wrote:
>
> SNIP
>
>>   	( eval $$cmd ) >> $@ 2>&1 && \
>>   	rm -f $@
>>   
>> +KBUILD_OUTPUT_DIR := ../..
>> +ifneq ($(O),)
>> +  KBUILD_OUTPUT_DIR := $(O)
>> +endif
>> +
>>   make_kernelsrc:
>>   	@echo "- make -C <kernelsrc> $(PARALLEL_OPT) tools/perf"
>>   	$(call clean); \
>>   	(make -C ../.. $(PARALLEL_OPT) tools/perf) > $@ 2>&1 && \
>> -	test -x perf && rm -f $@ || (cat $@ ; false)
>> +	test -x $(KBUILD_OUTPUT_DIR)/tools/perf && rm -f $@ || (cat $@ ; false)
> do you miss one extra /perf in here? like it should be
>
>     test -x $(KBUILD_OUTPUT_DIR)/tools/perf/perf

Right. Will fix.

Thank you.