linux-kernel - Re: [PATCH] clocksource: ftm: select CLKSRC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 14 Jan 2016 13:23:44 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org, Stefan Agner <stefan@...er.ch>,
	Xiubo Li <Li.Xiubo@...escale.com>,
	Sascha Hauer <kernel@...gutronix.de>,
	Shawn Guo <shawnguo@...nel.org>
Subject: Re: [PATCH] clocksource: ftm: select CLKSRC_MMIO

On Thursday 14 January 2016 10:25:40 Daniel Lezcano wrote:
> On 01/14/2016 12:02 AM, Arnd Bergmann wrote:
> > The ftm clocksource driver does not build if CLKSRC_MMIO is disabled:
> >
> > drivers/built-in.o: In function `ftm_timer_init':
> > (init.text+0xd324): undefined reference to `clocksource_mmio_init'
> > (init.text+0xd484): undefined reference to `clocksource_mmio_readl_up'
> >
> > This adds the same 'select' statement that the other similar drivers
> > use. Prior to allowing this driver to be enabled with COMPILE_TEST,
> > it was apparently unused. I'm not entirely sure who is using this
> > hardware, but it certainly can't hurt to ensure it builds cleanly.
> 
> Hi Arnd,
> 
> Thanks for the fix. It is already in Thomas's tree [1].

Ok, thanks for fixing it already! I'll mark this one as superceded
in my randconfig testing git tree then and will drop it as soon as
yours is merged.

	Arnd