linux-kernel - Re: [PATCH 16/16] mm/slab: introduce new slab management type, OBJFREELIST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1601140929280.2145@east.gentwo.org>
Date:	Thu, 14 Jan 2016 09:32:19 -0600 (CST)
From:	Christoph Lameter <cl@...ux.com>
To:	Joonsoo Kim <js1304@...il.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Pekka Enberg <penberg@...nel.org>,
	David Rientjes <rientjes@...gle.com>,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	Jesper Dangaard Brouer <brouer@...hat.com>,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 16/16] mm/slab: introduce new slab management type,
 OBJFREELIST_SLAB

On Thu, 14 Jan 2016, Joonsoo Kim wrote:

> SLAB needs a array to manage freed objects in a slab. It is only used
> if some objects are freed so we can use free object itself as this array.
> This requires additional branch in somewhat critical lock path to check
> if it is first freed object or not but that's all we need. Benefits is
> that we can save extra memory usage and reduce some computational
> overhead by allocating a management array when new slab is created.

Hmmm... But then you need to have an offset in the page struct to
figure out where the freelist starts. One additional level of indirection.
Seems to have some negative impact on performance.

> In my system, without enabling CONFIG_DEBUG_SLAB, Almost caches become
> OBJFREELIST_SLAB and NORMAL_SLAB (using leftover) which doesn't waste
> memory. Following is the result of number of caches with specific slab
> management type.

Sounds good.