linux-kernel - Re: [PATCH 03/16] mm/slab: remove the checks for slab implementation bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAmzW4M61B4h4HgwKDOTdVqDRav6ZOxcK5F7R_4HaitE7c+8zQ@mail.gmail.com>
Date:	Fri, 15 Jan 2016 01:20:43 +0900
From:	Joonsoo Kim <js1304@...il.com>
To:	Christoph Lameter <cl@...ux.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Pekka Enberg <penberg@...nel.org>,
	David Rientjes <rientjes@...gle.com>,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	Jesper Dangaard Brouer <brouer@...hat.com>,
	Linux Memory Management List <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 03/16] mm/slab: remove the checks for slab implementation bug

2016-01-15 0:23 GMT+09:00 Christoph Lameter <cl@...ux.com>:
> On Thu, 14 Jan 2016, Joonsoo Kim wrote:
>
>> Some of "#if DEBUG" are for reporting slab implementation bug
>> rather than user usecase bug. It's not really needed because slab
>> is stable for a quite long time and it makes code too dirty. This
>> patch remove it.
>
> Maybe better convert them to VM_BUG_ON() or so?

It's one possible solution but I'd like to make slab.c clean
as much as possible. Nowadays, SLAB code isn't changed
so much, therefore I don't think we need to keep them.

Thanks.