linux-kernel - Re: [PATCH v2 06/11] don't put symlink bodies in pagecache into highmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwtrHfckEdZy6_5jbjc7nuMTTM5Pz=A6sYt_h6+0MXcug@mail.gmail.com>
Date:	Thu, 14 Jan 2016 15:58:22 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Al Viro <viro@...iv.linux.org.uk>
Cc:	Tomeu Vizoso <tomeu@...euvizoso.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Neil Brown <neilb@...e.com>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH v2 06/11] don't put symlink bodies in pagecache into highmem

On Thu, Jan 14, 2016 at 2:25 PM, Al Viro <viro@...iv.linux.org.uk> wrote:
>
> For one thing, we'll lose RCU ->get_link() for those.

Why couldn't we just do that in the RCU walker? kmap should be fine..

That said, as long as you think it's ok now, I guess I don't care.
Having some sanity testing in __add_to_page_cache_locked might be a
good safety net.

             Linus