linux-kernel - Re: [PATCH v2 03/10] Input: synaptics-rmi4: Add device tree support for RMI4 I2C devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFmnZc3Ce40CT9V8X223aPxfbRXUcRX5RvK=0GitQ5yrPVXhOg@mail.gmail.com>
Date:	Fri, 15 Jan 2016 14:24:15 +0300
From:	Andrey Gusakov <andrey.gusakov@...entembedded.com>
To:	Andrew Duggan <aduggan@...aptics.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Jiri Kosina <jikos@...nel.org>,
	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	Christopher Heiny <cheiny@...aptics.com>,
	Stephen Chandler Paul <cpaul@...hat.com>,
	Vincent Huang <vincent.huang@...synaptics.com>,
	Chris Healy <cphealy@...il.com>, Rob Herring <robh@...nel.org>,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v2 03/10] Input: synaptics-rmi4: Add device tree support
 for RMI4 I2C devices

On Fri, Jan 15, 2016 at 2:44 AM, Andrew Duggan <aduggan@...aptics.com> wrote:
>
> Add devicetree binding for I2C devices and add bindings for optional
> parameters in the function drivers. Parameters for function drivers are
> defined in child nodes for each of the functions.
>
> Signed-off-by: Andrew Duggan <aduggan@...aptics.com>
...
> +#ifdef CONFIG_OF
> +static void rmi_function_of_probe(struct rmi_function *fn)
> +{
> +       char of_name[8];
> +
> +       snprintf(of_name, sizeof(of_name), "rmi4-f%02x",
> +               fn->fd.function_number);
> +       fn->dev.of_node = of_find_node_by_name(
> +                               fn->rmi_dev->xport->dev->of_node, of_name);
> +}
>
Name like "rmi4-f11" including 0 terminator does not fit in 8 chars.
This leads to the inability to find the correct OF node and get settings.

Sorry for previous HTML noise.