[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5698DC52.4050808@users.sourceforge.net>
Date: Fri, 15 Jan 2016 12:47:30 +0100
From: SF Markus Elfring <elfring@...rs.sourceforge.net>
To: Joe Perches <joe@...ches.com>, netdev@...r.kernel.org
Cc: Claudiu Manoil <claudiu.manoil@...escale.com>,
LKML <linux-kernel@...r.kernel.org>,
kernel-janitors@...r.kernel.org,
Julia Lawall <julia.lawall@...6.fr>
Subject: Re: gianfar: Less function calls in gfar_ethflow_to_filer_table()
after error detection
>> * Return directly if a memory allocation failed at the beginning.
>>
>> * Adjust jump targets according to the Linux coding style convention.
>>
>> This issue was detected by using the Coccinelle software.
>
> Is this really better?
>
> Perhaps this particular static analysis isn't too useful.
The opinions are still evolving for such a kind of search pattern.
> Why not just allocate once and assign a second pointer?
>
> local_rqfpr = kmalloc_array(2 * (MAX_FILER_IDX + 1),
> sizeof(unsigned int), GFP_KERNEL);
> if (!local_rqfpr)
> goto err;
>
> local_rqfcr = &local_rqfpr[MAX_FILER_IDX + 1];
Do you suggest to use only one array (instead of two as before) here?
Regards,
Markus
Powered by blists - more mailing lists