linux-kernel - Re: [PATCH] drm: nouveau: fix nouveau_debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1213515825.56151.1452859661690.JavaMail.open-xchange@www.ud-mail.de>
Date:	Fri, 15 Jan 2016 13:07:41 +0100 (CET)
From:	Karol Herbst <nouveau@...olherbst.de>
To:	Arnd Bergmann <arnd@...db.de>,
	Emil Velikov <emil.l.velikov@...il.com>
Cc:	bskeggs <bskeggs@...hat.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	LAKML <linux-arm-kernel@...ts.infradead.org>,
	dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH] drm: nouveau: fix nouveau_debugfs_init prototype

> Emil Velikov <emil.l.velikov@...il.com> hat am 15. Januar 2016 um 12:06
> geschrieben:
> 
> On 13 January 2016 at 16:00, Arnd Bergmann <arnd@...db.de> wrote:
> > On Wednesday 13 January 2016 14:55:47 Karol Herbst wrote:
> >> > Arnd Bergmann <arnd@...db.de> hat am 13. Januar 2016 um 14:48
> >> > geschrieben:
> >> >
> >> > The new debugfs initialization code fails to build when CONFIG_DEBUG_FS
> >> > is disabled:
> >> >
> >> > In file included from
> >> > /git/arm-soc/drivers/gpu/drm/nouveau/nouveau_drm.c:57:0:
> >> > drivers/gpu/drm/nouveau/nouveau_debugfs.h: In function
> >> > 'nouveau_debugfs_init':
> >> > drivers/gpu/drm/nouveau/nouveau_debugfs.h:37:29: error: parameter name
> >> > omitted
> >> > nouveau_debugfs_init(struct nouveau_drm *)
> >> >
> >> > This fixes the prototypes so we can build it again.
> >> >
> >>
> >> thanks for this. I already send a patch to the nouveau ML here:
> >> http://lists.freedesktop.org/archives/nouveau/2016-January/023779.html
> >
> > Ok, thanks
> >
> Fwiw Arnd's fix feels a lot better - it lacks typos, has a fixes tag,
> comprehensive commit message etc. etc. :-)
> 
> -Emil

no worries, I am still learning after all

Karol