linux-kernel - Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst settings device tree options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5698F846.5080604@tabi.org>
Date:	Fri, 15 Jan 2016 07:46:46 -0600
From:	Timur Tabi <timur@...i.org>
To:	Mark Brown <broonie@...nel.org>
Cc:	Nicolin Chen <nicoleotsuka@...il.com>,
	Caleb Crome <caleb@...me.org>, Xiubo Li <Xiubo.Lee@...il.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, alsa-devel@...a-project.org
Subject: Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst
 settings device tree options

Mark Brown wrote:
>> >I admit it's a grey area, but the hardware doesn't work if you use the wrong
>> >value, and it is a fixed value per device.  A p1022ds would use a different
>> >value than in in i.MX6, and once you pick a value, it's the same no matter
>> >which sample rate, buffer size, etc you choose.

> Caleb's original message suggested this was rate dependant.

Yeah, I just noticed that.  In that case, I agree that a device tree 
property is inappropriate, unless it's an array that contains tuples of 
sample rates and watermark/maxburst settings.  That would get unwieldy 
very easily, though.