linux-kernel - Re: [PATCH v3 02/13] clk: at91: make use of syscon/regmap internally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160115021026.GR22188@codeaurora.org>
Date:	Thu, 14 Jan 2016 18:10:26 -0800
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:	Nicolas Ferre <nicolas.ferre@...el.com>,
	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Michael Turquette <mturquette@...libre.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-clk@...r.kernel.org
Subject: Re: [PATCH v3 02/13] clk: at91: make use of syscon/regmap internally

On 12/04, Alexandre Belloni wrote:
> diff --git a/drivers/clk/at91/clk-generated.c b/drivers/clk/at91/clk-generated.c
> index abc80949e1dd..0b9e0aeef346 100644
> --- a/drivers/clk/at91/clk-generated.c
> +++ b/drivers/clk/at91/clk-generated.c
> @@ -17,9 +17,13 @@
>  #include <linux/of.h>
>  #include <linux/of_address.h>
>  #include <linux/io.h>
> +#include <linux/mfd/syscon.h>
> +#include <linux/regmap.h>
>  
>  #include "pmc.h"
>  
> +extern spinlock_t pmc_pcr_lock;

You can throw this extern into pmc.h?

> +
>  #define PERIPHERAL_MAX		64
>  #define PERIPHERAL_ID_MIN	2
>  
-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project