[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160115175757.GA6588@sirena.org.uk>
Date: Fri, 15 Jan 2016 17:57:57 +0000
From: Mark Brown <broonie@...nel.org>
To: Wenyou Yang <wenyou.yang@...el.com>
Cc: Liam Girdwood <lgirdwood@...il.com>,
Rob Herring <robh+dt@...nel.org>,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
Nicolas Ferre <nicolas.ferre@...el.com>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org
Subject: Re: [PATCH 1/2] regulator: act8945a: add regulator driver for
ACT8945A
On Fri, Jan 08, 2016 at 10:08:57AM +0800, Wenyou Yang wrote:
> + np = of_get_child_by_name(pdev->dev.of_node, "regulators");
> + if (!np) {
> + dev_err(&pdev->dev, "regulator node not found\n");
> + return -EINVAL;
> + }
> +
> + matches = act8945a_matches;
> + num_matches = ARRAY_SIZE(act8945a_matches);
> +
> + ret = of_regulator_match(&pdev->dev, np, matches, num_matches);
Don't open code this, use the core regulators_node and of_match
implementation instead.
> + dev_info(act8945a_dev->dev, "%s regulator registered\n",
> + desc->name);
This is just noise, please remove it - let the core handle notifying
users.
> +static int __init act8945a_pmic_init(void)
> +{
> + return platform_driver_register(&act8945a_pmic_driver);
> +}
> +subsys_initcall(act8945a_pmic_init);
Please use module_platform_driver() unless there is a strong reason to
do otherwise.
Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)
Powered by blists - more mailing lists