linux-kernel - Re: Re: [PATCH V2 1/7] usb-misc: sisusbvga: Fix coding style: horizontal whitespace changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 15 Jan 2016 13:21:06 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Peter Senna <peter.senna@...labora.co.uk>
cc:	Joe Perches <joe@...ches.com>,
	<sergei.shtylyov@...entembedded.com>,
	Peter Senna Tschudin <peter.senna@...labora.com>,
	<gregkh@...uxfoundation.org>, <linux-kernel@...r.kernel.org>,
	<thomas@...ischhofer.net>, <linux-usb@...r.kernel.org>
Subject: Re: Re: [PATCH V2 1/7] usb-misc: sisusbvga: Fix coding style: horizontal whitespace changes

On Fri, 15 Jan 2016, Peter Senna wrote:

> CC: Alan Stern <stern@...land.harvard.edu>
> 
> On Friday, January 15, 2016 18:56 CET, Joe Perches <joe@...ches.com> wrote: 
>  
> > On Fri, 2016-01-15 at 18:41 +0100, Peter Senna Tschudin wrote:
> > > This patch fixes whitespace coding style issues that can be fixed
> > > within a single line.
> > 
> > trivia:
> > 
> > > diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c
> > []
> > > @@ -549,7 +549,7 @@ static int sisusb_recv_bulk_msg(struct sisusb_usb_data *sisusb, int ep, int len,
> > >  }
> > >  
> > >  static int sisusb_send_packet(struct sisusb_usb_data *sisusb, int len,
> > > -						struct sisusb_packet *packet)
> > > +		struct sisusb_packet *packet)
> > 
> > I think all of these should use indentation alignment
> > to open parenthesis.
> That was my original idea too, but I have the impression things are different for usb, at least for usb-host. Alan, can you comment on this continuation line style issue here?

Different files use different alignment for continuation lines.  I use
the style I like (two extra tabs) for the code I write, but other
people make different choices.  Unless I happen to be the maintainer or
an active contributor for the source file in question, my preferences
don't matter much.

Alan Stern