linux-kernel - Re: [PATCH] Input: DT binding: Change touchscreen to touch for use with touchscreens and touchpads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56994692.1040701@synaptics.com>
Date:	Fri, 15 Jan 2016 11:20:50 -0800
From:	Andrew Duggan <aduggan@...aptics.com>
To:	Rob Herring <robh@...nel.org>
CC:	<linux-input@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Jiri Kosina <jikos@...nel.org>,
	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	Christopher Heiny <cheiny@...aptics.com>,
	Stephen Chandler Paul <cpaul@...hat.com>,
	Vincent Huang <vincent.huang@...synaptics.com>,
	Chris Healy <cphealy@...il.com>,
	Andrey Gusakov <andrey.gusakov@...entembedded.com>,
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH] Input: DT binding: Change touchscreen to touch for use
 with touchscreens and touchpads

Hi Rob,

On 01/14/2016 07:29 PM, Rob Herring wrote:
> On Thu, Jan 14, 2016 at 03:42:45PM -0800, Andrew Duggan wrote:
>> These generic touchscreen bindings can also be used for touchpads.
>> Instead of creating new generic bindings this patch just renames then to
>> touch-*.
>>
>> Signed-off-by: Andrew Duggan <aduggan@...aptics.com>
>> ---
>> It was suggested that for the synaptics-rmi4 driver I use the generic
>> bindings. But, since the rmi4 driver is used for both touchpads and
>> touchscreens it seemed weird to have a touchpad with a parameter
>> of touchscreen-inverted-y. I changed all of the references to it in the
>> source tree. But, I realize this could cause a backwards compatibilty
>> issue with device trees which are not included in the kernel.
> It does and you cannot do this. Live with the weirdness or support both
> names...

Ok, I had a feeling this wouldn't go over well. I guess I'll try living 
with the weirdness for now.

Thanks,
Andrew

> Rob