linux-kernel - Re: [PATCHv8 0/5] Driver for new "VMD" device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160115193206.GB13227@localhost.localdomain>
Date:	Fri, 15 Jan 2016 19:32:06 +0000
From:	Keith Busch <keith.busch@...el.com>
To:	Bjorn Helgaas <helgaas@...nel.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
	linux-pci@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Bryan Veal <bryan.e.veal@...el.com>,
	Jon Derrick <jonathan.derrick@...el.com>
Subject: Re: [PATCHv8 0/5] Driver for new "VMD" device

On Fri, Jan 15, 2016 at 12:19:38PM -0600, Bjorn Helgaas wrote:
> I applied these to pci/host-vmd with the changes below.  Most of them
> are cosmetic (rewrapping changelogs, fixing whitespace, etc.), but
> there are a few I'd like you to take a close look at:
> 
>   - Added VMD_CFGBAR and similar #defines
>   - Added vmd_cfg_addr() to factor out the addr computation and
>     validation
>   - Resource setup in vmd_enable_domain().  I suggested a temporary to
>     make the lines shorter.  I had the vmd->dev->resource[n] in mind,
>     but you added a temporary for vmd->resources[n].  Either way is
>     fine, but I liked the look of the v7 init, so I reverted to that,
>     with a temporary for vmd->dev->resource[n].
>   - Flags setup in vmd_enable_domain().  This was pretty confusing,
>     and I *think* what I did is equivalent, but you should verify.

Thanks for the cleanups. All the new changes look good to me, and I will
test your tree today to confirm no regressions.
 
> I'm still hoping to get this in during the merge window.

Thanks a bunch. This would be great timing to align the hardware
availability with various software and OEM vendors.
 
> If you want to test this, I recommend using my git branch
> https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=pci/host-vmd
> instead of applying the patch below on top of your v8.  If you want
> to make changes, post an incremental patch based on that branch.

I'll give this a test today.