linux-kernel - Re: [Xen-devel] [PATCH] xen/gntdev: Don't allocate struct gntdev_copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56994E1E.2070000@oracle.com>
Date:	Fri, 15 Jan 2016 14:53:02 -0500
From:	Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:	Andrew Cooper <andrew.cooper3@...rix.com>, konrad.wilk@...cle.com,
	david.vrabel@...rix.com
Cc:	xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org
Subject: Re: [Xen-devel] [PATCH] xen/gntdev: Don't allocate struct
 gntdev_copy_batch on stack

On 01/15/2016 02:50 PM, Andrew Cooper wrote:
> On 15/01/16 19:43, Boris Ostrovsky wrote:
>> @@ -933,18 +937,20 @@ static long gntdev_ioctl_grant_copy(struct gntdev_priv *priv, void __user *u)
>>   			goto out;
>>   		}
>>   
>> -		ret = gntdev_grant_copy_seg(&batch, &seg, &copy.segments[i].status);
>> +		ret = gntdev_grant_copy_seg(batch, &seg,
>> +			&copy.segments[i].status);
>>   		if (ret < 0)
>>   			goto out;
>>   
>>   		cond_resched();
>>   	}
>> -	if (batch.nr_ops)
>> -		ret = gntdev_copy(&batch);
>> +	if (batch->nr_ops)
>> +		ret = gntdev_copy(batch);
> You presumably want a kfree() here?

Ah, missed it. Thanks.

>
>>   	return ret;
>>