linux-kernel - Re: [PATCH] input: serio: drop warnings in case of EPROBE_DEFER from serio_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9158432.BHbKetFqR6@vostro.rjw.lan>
Date:	Fri, 15 Jan 2016 21:53:14 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Grygorii Strashko <grygorii.strashko@...com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, nsekhar@...com,
	linux-kernel@...r.kernel.org, lkp@...org
Subject: Re: [PATCH] input: serio: drop warnings in case of EPROBE_DEFER from serio_find_driver()

On Friday, January 15, 2016 08:01:15 PM Grygorii Strashko wrote:
> Now serio_find_driver() will print warnings in case device_attach()
> returns -EPROBE_DEFER. Those warnings are obsolete, in genral, because:
> - DD core can report the same if required
> - since commit 013c074f8642 ("PM / sleep: prohibit devices probing
> during suspend/hibernation") the devices probing is prohibited during
> System suspend and deferred device will be carefully reprobed once
> Resume is finished.
> 
> Hence, drop warnings in case of EPROBE_DEFER from serio_find_driver().
> 
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc: Rafael J. Wysocki <rjw@...ysocki.net>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

> ---
>  drivers/input/serio/serio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/serio/serio.c b/drivers/input/serio/serio.c
> index 8f82897..1ca7f55 100644
> --- a/drivers/input/serio/serio.c
> +++ b/drivers/input/serio/serio.c
> @@ -134,7 +134,7 @@ static void serio_find_driver(struct serio *serio)
>  	int error;
>  
>  	error = device_attach(&serio->dev);
> -	if (error < 0)
> +	if (error < 0 && error != -EPROBE_DEFER)
>  		dev_warn(&serio->dev,
>  			 "device_attach() failed for %s (%s), error: %d\n",
>  			 serio->phys, serio->name, error);
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.