linux-kernel - Re: [git pull] vfs.git regression fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160115210046.GG17997@ZenIV.linux.org.uk>
Date:	Fri, 15 Jan 2016 21:00:46 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [git pull] vfs.git regression fix

On Fri, Jan 15, 2016 at 12:41:06PM -0800, Linus Torvalds wrote:
> Al,
>  _please_ learn to be more careful about your pull requests.
> 
> This one is garbage.
> 
> Why?
> 
> You ask me to pull from the wrong source. You ask me to pull from
> 
>    git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
> 
> but that is some random state from January 2014. Two years ago.
> 
> What you actually *meant* was apparently the "for-linus" branch, since
> that matches the shortlog and diffstat. But that's not what your pull
> request asked me to pull.
> 
> This is not the first time. You seem to either use buggy scripts, or
> do this (wrong) by hand. Please fix whatever it is, so that I don't
> have to go look or guess after I notice that I pulled crap.

Buggy scripts, actually.  The thing that generates them takes a branch
name as argument; turns out that it (pretty much by accident) treats the
missing argument as HEAD.  Which tends to give reasonable diffstat and
shortlog, so I hadn't spotted the missing check until now.

Fixed.  BTW, is there any better way to get the current branch name than
git branch |sed -ne '/\* /s///p'?