linux-kernel - Re: [PATCH v2 3/9] perf build: Test correct path of perf in build-test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 15 Jan 2016 11:32:42 +0800
From:	"Wangnan (F)" <wangnan0@...wei.com>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	pi3orama <pi3orama@....com>
CC:	<jolsa@...hat.com>, <linux-kernel@...r.kernel.org>,
	<lizefan@...wei.com>, Jiri Olsa <jolsa@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH v2 3/9] perf build: Test correct path of perf in build-test



On 2016/1/15 10:57, Wangnan (F) wrote:
>
>
[SNIP]
>
> Concultion: the reason of the problem you met is because 'make clean 
> O=.' doesn't clean
> feature test results. In v1 I have:
>
> -clean := @(cd $(PERF); make -s -f $(MK) clean >/dev/null)
> +clean := @(cd $(PERF); make -s -f $(MK) O=$(PERF_OUT) clean 
> >/dev/null; make -s -f $(MK) clean >/dev/null)
>
> (two 'make clean' here for safety)
>
> But removes them in v2. The second 'make clean' would remove any 
> feature testing
> results and return good testing result for you. This also explain why 
> I never met failure
> like this: if patch 4 - 9 are applied, make static would use feature 
> dump.
>
> Let me see how to remove feature testing results.

Here:

config-clean:
         $(call QUIET_CLEAN, config)
         $(Q)$(MAKE) -C $(srctree)/tools/build/feature/ $(if 
$(OUTPUT),OUTPUT=$(OUTPUT)feature/,) clean >/dev/null

If we build with 'O', feature test directory would reside in 
$(OUTPUT)/feature. Then when
we 'make clean', the resuling .bin files are removed from 
$(OUTPUT)/feature. However, if we
build without 'O' but clean with 'O=.', make clean tries to remove 
./feature, but should be
../build/feature.

Thank you.