[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <569A3F7C.2050400@kernel.org>
Date: Sat, 16 Jan 2016 13:02:52 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Gabriele Mazzotta <gabriele.mzt@...il.com>
Cc: knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net, marex@...x.de,
marxin.liska@...il.com, linux-iio@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] iio: light: acpi-als: Report data as processed
On 12/01/16 15:21, Gabriele Mazzotta wrote:
> As per the ACPI specification (Revision 5.0) [1], the data coming
> from the sensor represent the ambient light illuminance reading
> expressed in lux. So use IIO_CHAN_INFO_PROCESSED to signify that
> the data are pre-processed.
>
> However, to keep backward ABI compatibility, the IIO_CHAN_INFO_RAW
> bit is not removed.
>
> [1] http://www.acpi.info/DOWNLOADS/ACPIspec50.pdf
>
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@...il.com>
Applied to the fixes-togreg branch and marked for stable.
I added a bit to the commit message including that bug report you found for
iio-sensor-proxy as additional justification for the stable marking
and sending it as a fix.
Jonathan
> ---
> drivers/iio/light/acpi-als.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/light/acpi-als.c b/drivers/iio/light/acpi-als.c
> index 60537ec..53201d9 100644
> --- a/drivers/iio/light/acpi-als.c
> +++ b/drivers/iio/light/acpi-als.c
> @@ -54,7 +54,9 @@ static const struct iio_chan_spec acpi_als_channels[] = {
> .realbits = 32,
> .storagebits = 32,
> },
> - .info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
> + /* _RAW is here for backward ABI compatibility */
> + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |
> + BIT(IIO_CHAN_INFO_PROCESSED),
> },
> };
>
> @@ -152,7 +154,7 @@ static int acpi_als_read_raw(struct iio_dev *indio_dev,
> s32 temp_val;
> int ret;
>
> - if (mask != IIO_CHAN_INFO_RAW)
> + if ((mask != IIO_CHAN_INFO_PROCESSED) && (mask != IIO_CHAN_INFO_RAW))
> return -EINVAL;
>
> /* we support only illumination (_ALI) so far. */
>
Powered by blists - more mailing lists