linux-kernel - Re: [PATCH 4.2.y-ckt 161/305] um: Fix get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <569AAB91.4090904@nod.at>
Date:	Sat, 16 Jan 2016 21:44:01 +0100
From:	Richard Weinberger <richard@....at>
To:	Kamal Mostafa <kamal@...onical.com>, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, kernel-team@...ts.ubuntu.com
Subject: Re: [PATCH 4.2.y-ckt 161/305] um: Fix get_signal() usage

Am 16.01.2016 um 00:59 schrieb Kamal Mostafa:
> 4.2.8-ckt2 -stable review patch.  If anyone has any objections, please let me know.
> 
> ---8<------------------------------------------------------------
> 
> From: Richard Weinberger <richard@....at>
> 
> commit db2f24dc240856fb1d78005307f1523b7b3c121b upstream.
> 
> If get_signal() returns us a signal to post
> we must not call it again, otherwise the already
> posted signal will be overridden.
> Before commit a610d6e672d this was the case as we stopped
> the while after a successful handle_signal().
> 
> Fixes: a610d6e672d ("pull clearing RESTORE_SIGMASK into block_sigmask()")
> Signed-off-by: Richard Weinberger <richard@....at>
> Signed-off-by: Kamal Mostafa <kamal@...onical.com>
> ---
>  arch/um/kernel/signal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/um/kernel/signal.c b/arch/um/kernel/signal.c
> index 4f60e4a..50b6e9f 100644
> --- a/arch/um/kernel/signal.c
> +++ b/arch/um/kernel/signal.c
> @@ -69,7 +69,7 @@ static int kern_do_signal(struct pt_regs *regs)
>  	struct ksignal ksig;
>  	int handled_sig = 0;
>  
> -	while (get_signal(&ksig)) {
> +	if (get_signal(&ksig)) {
>  		handled_sig = 1;
>  		/* Whee!  Actually deliver the signal.  */
>  		handle_signal(&ksig, regs);
> 

Please drop this patch, it will be reverted from Linus' tree soon.

Thanks,
//richard