linux-kernel - Re: [PATCH v5 05/11] of: earlycon: Initialize port fields from DT properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201601170514.bkJqTMJP%fengguang.wu@intel.com>
Date:	Sun, 17 Jan 2016 05:54:40 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Peter Hurley <peter@...leysoftware.com>
Cc:	kbuild-all@...org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Rob Herring <robh@...nel.org>,
	Grant Likely <grant.likely@...aro.org>,
	Jiri Slaby <jslaby@...e.cz>, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org, Kevin Cernekee <cernekee@...il.com>,
	Jon Hunter <jonathanh@...dia.com>,
	Paul Burton <paul.burton@...tec.com>,
	Masahiro Yamada <yamada.masahiro@...ionext.com>,
	Sebastian Frias <sf84@...oste.net>,
	Peter Hurley <peter@...leysoftware.com>
Subject: Re: [PATCH v5 05/11] of: earlycon: Initialize port fields from DT
 properties

Hi Peter,

[auto build test ERROR on tty/tty-testing]
[also build test ERROR on v4.4 next-20160115]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Peter-Hurley/Earlycon-cleanup/20160117-054602
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: x86_64-randconfig-x012-201603 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

   drivers/tty/serial/earlycon.c: In function 'of_setup_earlycon':
>> drivers/tty/serial/earlycon.c:235:8: error: implicit declaration of function 'of_get_flat_dt_prop' [-Werror=implicit-function-declaration]
     val = of_get_flat_dt_prop(node, "reg-offset", NULL);
           ^
>> drivers/tty/serial/earlycon.c:235:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
     val = of_get_flat_dt_prop(node, "reg-offset", NULL);
         ^
   drivers/tty/serial/earlycon.c:238:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
     val = of_get_flat_dt_prop(node, "reg-shift", NULL);
         ^
>> drivers/tty/serial/earlycon.c:241:61: warning: comparison between pointer and integer
     big_endian = of_get_flat_dt_prop(node, "big-endian", NULL) != NULL ||
                                                                ^
   drivers/tty/serial/earlycon.c:243:53: warning: comparison between pointer and integer
       of_get_flat_dt_prop(node, "native-endian", NULL) != NULL);
                                                        ^
   drivers/tty/serial/earlycon.c:244:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
     val = of_get_flat_dt_prop(node, "reg-io-width", NULL);
         ^
   cc1: some warnings being treated as errors

vim +/of_get_flat_dt_prop +235 drivers/tty/serial/earlycon.c

   229		spin_lock_init(&port->lock);
   230		port->iotype = UPIO_MEM;
   231		port->mapbase = addr;
   232		port->uartclk = BASE_BAUD * 16;
   233		port->membase = earlycon_map(addr, SZ_4K);
   234	
 > 235		val = of_get_flat_dt_prop(node, "reg-offset", NULL);
   236		if (val)
   237			port->mapbase += be32_to_cpu(*val);
   238		val = of_get_flat_dt_prop(node, "reg-shift", NULL);
   239		if (val)
   240			port->regshift = be32_to_cpu(*val);
 > 241		big_endian = of_get_flat_dt_prop(node, "big-endian", NULL) != NULL ||
   242			(IS_ENABLED(CONFIG_CPU_BIG_ENDIAN) &&
   243			 of_get_flat_dt_prop(node, "native-endian", NULL) != NULL);
   244		val = of_get_flat_dt_prop(node, "reg-io-width", NULL);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (21330 bytes)