linux-kernel - RE: [PATCH V3 0/2] AMD NTB V3 changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BLUPR12MB042080428FF23328B2D6685CEBC00@BLUPR12MB0420.namprd12.prod.outlook.com>
Date:	Mon, 18 Jan 2016 06:49:38 +0000
From:	"Yu, Xiangliang" <Xiangliang.Yu@....com>
To:	Jon Mason <jdmason@...zu.us>, Allen Hubbe <Allen.Hubbe@....com>
CC:	"dave.jiang@...el.com" <dave.jiang@...el.com>,
	"linux-ntb@...glegroups.com" <linux-ntb@...glegroups.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	SPG_Linux_Kernel <SPG_Linux_Kernel@....com>
Subject: RE: [PATCH V3 0/2] AMD NTB V3 changes


> > > I want to add flush function into ntb_transport.c, but I can't
> > > verify the implementation
> >
> > Ok.  That's a good reason to hold back the flush mechanism: it's not been
> tested.
> >
> > Nak (for now): [PATCH V3 2/2] NTB: Add support for flush request
> > interface
> >
> > Don't give up.  Please keep working on this, and the power management
> patch, to get them reviewed and accepted.  It's your choice whether or not
> to submit the patches, and when.  I'd encourage you to do it early, rather
> than delay.
> 
> I'd like to echo Allen's comment above.  Do not give up.  This code is very
> close to being accepted (once the issues that Allen and I pointed out are
> addressed).  If you can get us another version on/before Wednesday, it
> should make the 4.5 release (assuming it is acceptable and the wdinow is not
> closed prematurely).
> 
> Thanks for all of your hard work (and many thanks to Allen for his reviews of
> the code as well).

I'll change code right now and please help reviewed it again.