linux-kernel - Re: [PATCH] thermal: cpu_cooling: fix out of bounds access in time_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANMq1KCD0n1mdp2dU5mL5YZvk5SwMi+Nnwqr+c5Qi7FOPNg2PA@mail.gmail.com>
Date:	Mon, 18 Jan 2016 10:25:35 +0800
From:	Nicolas Boichat <drinkcat@...omium.org>
To:	Javi Merino <javi.merino@....com>
Cc:	Zhang Rui <rui.zhang@...el.com>,
	Eduardo Valentin <edubezval@...il.com>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	Amit Daniel Kachhap <amit.kachhap@...il.com>,
	Viresh Kumar <viresh.kumar@...aro.org>
Subject: Re: [PATCH] thermal: cpu_cooling: fix out of bounds access in time_in_idle

On Fri, Jan 15, 2016 at 11:20 PM, Javi Merino <javi.merino@....com> wrote:
> Eduardo, Rui,
>
> On Tue, Jan 05, 2016 at 07:19:25PM +0000, Javi Merino wrote:
>> On Mon, Dec 21, 2015 at 08:49:40AM +0530, Viresh Kumar wrote:
>> > On 19-12-15, 12:54, Javi Merino wrote:
>> > > In __cpufreq_cooling_register() we allocate the arrays for time_in_idle
>> > > and time_in_idle_timestamp to be as big as the number of cpus in this
>> > > cpufreq device.  However, in get_load() we access this array using the
>> > > cpu number as index, which can result in an out of bound access.
>> > >
>> > > Index time_in_idle{,_timestamp} using the index in the cpufreq_device's
>> > > allowed_cpus mask, as we do for the load_cpu array in
>> > > cpufreq_get_requested_power()
>> > >
>> > > Reported-by: Nicolas Boichat <drinkcat@...omium.org>
>> > > Cc: Amit Daniel Kachhap <amit.kachhap@...il.com>
>> > > Cc: Viresh Kumar <viresh.kumar@...aro.org>
>> > > Cc: Zhang Rui <rui.zhang@...el.com>
>> > > Cc: Eduardo Valentin <edubezval@...il.com>
>> > > Signed-off-by: Javi Merino <javi.merino@....com>
>> > > ---
>> > >  drivers/thermal/cpu_cooling.c | 14 ++++++++------
>> > >  1 file changed, 8 insertions(+), 6 deletions(-)
>> >
>> > Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
>>
>> If there are no more objections, can you pick this up?
>
> Another gentle ping, can this be merged?

Tested-by: Nicolas Boichat <drinkcat@...omium.org>