linux-kernel - Re: [PATCH] Fix: PowerNV crash with 4.4.0-rc8 at sched_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <969916137.9009700.1453115182823.JavaMail.zimbra@redhat.com>
Date:	Mon, 18 Jan 2016 06:06:22 -0500 (EST)
From:	Jan Stancek <jstancek@...hat.com>
To:	Raghavendra K T <raghavendra.kt@...ux.vnet.ibm.com>
Cc:	mingo@...hat.com, peterz@...radead.org, benh@...nel.crashing.org,
	paulus@...ba.org, mpe@...erman.id.au, anton@...ba.org,
	akpm@...ux-foundation.org, gkurz@...ux.vnet.ibm.com,
	grant likely <grant.likely@...aro.org>,
	nikunj@...ux.vnet.ibm.com, vdavydov@...allels.com,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: [PATCH] Fix: PowerNV crash with 4.4.0-rc8 at sched_init_numa





----- Original Message -----
> From: "Raghavendra K T" <raghavendra.kt@...ux.vnet.ibm.com>
> To: mingo@...hat.com, peterz@...radead.org, benh@...nel.crashing.org, paulus@...ba.org, mpe@...erman.id.au,
> anton@...ba.org, akpm@...ux-foundation.org
> Cc: jstancek@...hat.com, gkurz@...ux.vnet.ibm.com, "grant likely" <grant.likely@...aro.org>,
> nikunj@...ux.vnet.ibm.com, vdavydov@...allels.com, "raghavendra kt" <raghavendra.kt@...ux.vnet.ibm.com>,
> linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org, linux-mm@...ck.org
> Sent: Friday, 15 January, 2016 8:01:23 PM
> Subject: [PATCH] Fix: PowerNV crash with 4.4.0-rc8 at sched_init_numa
> 
> Commit c118baf80256 ("arch/powerpc/mm/numa.c: do not allocate bootmem
> memory for non existing nodes") avoided bootmem memory allocation for
> non existent nodes.
> 
> When DEBUG_PER_CPU_MAPS enabled, powerNV system failed to boot because
> in sched_init_numa, cpumask_or operation was done on unallocated nodes.
> Fix that by making cpumask_or operation only on existing nodes.
> 
> [ Tested with and w/o DEBUG_PER_CPU_MAPS on x86 and powerpc ]
> 
> Reported-by: Jan Stancek <jstancek@...hat.com>

Tested-by: Jan Stancek <jstancek@...hat.com>

I also verified with my setup, that this made the crash go away.
Report mail thread for reference:
  https://lists.ozlabs.org/pipermail/linuxppc-dev/2016-January/137691.html

Regards,
Jan

> Signed-off-by: Raghavendra K T <raghavendra.kt@...ux.vnet.ibm.com>
> ---
>  kernel/sched/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 44253ad..474658b 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -6840,7 +6840,7 @@ static void sched_init_numa(void)
>  
>  			sched_domains_numa_masks[i][j] = mask;
>  
> -			for (k = 0; k < nr_node_ids; k++) {
> +			for_each_node(k) {
>  				if (node_distance(j, k) > sched_domains_numa_distance[i])
>  					continue;
>  
> --
> 1.7.11.7
> 
>