linux-kernel - Re: [PATCH] bio: Make the test correct for idx in __bio_clone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160118130015.GA4069@dhcp-129-109.nay.redhat.com>
Date:	Mon, 18 Jan 2016 21:00:15 +0800
From:	Minfei Huang <mnfhuang@...il.com>
To:	axboe@...nel.dk
Cc:	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
	mhuang@...hat.com
Subject: Re: [PATCH] bio: Make the test correct for idx in __bio_clone_fast

Ping.
Any comment is appreciate.

Thanks
Minfei

On 12/19/15 at 01:09P, Minfei Huang wrote:
> It is more lucky that kernel crash does not happen, since we test the
> bi_pool in function __bio_clone_fast.
> 
> The idx will be still equal to BIO_POOL_NONE, if there is no bvec to be
> allocated.
> 
> Fix the bug_on condition to make the test correct.
> 
> Signed-off-by: Minfei Huang <mnfhuang@...il.com>
> ---
>  block/bio.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/block/bio.c b/block/bio.c
> index 4f184d9..041ece0 100644
> --- a/block/bio.c
> +++ b/block/bio.c
> @@ -573,8 +573,7 @@ EXPORT_SYMBOL(bio_phys_segments);
>   */
>  void __bio_clone_fast(struct bio *bio, struct bio *bio_src)
>  {
> -	BUG_ON(bio->bi_pool && BIO_POOL_IDX(bio) != BIO_POOL_NONE);
> -
> +	BUG_ON(BIO_POOL_IDX(bio) != BIO_POOL_NONE);
>  	/*
>  	 * most users will be overriding ->bi_bdev with a new target,
>  	 * so we don't set nor calculate new physical/hw segment counts here
> -- 
> 2.6.3
>