linux-kernel - Re: lib: sw842: select crc32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160118152457.GD717@gondor.apana.org.au>
Date:	Mon, 18 Jan 2016 23:24:57 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Dan Streetman <ddstreet@...e.org>, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: lib: sw842: select crc32

On Wed, Jan 13, 2016 at 11:24:02PM +0100, Arnd Bergmann wrote:
> The sw842 library code was merged in linux-4.1 and causes a very rare randconfig
> failure when CONFIG_CRC32 is not set:
>     
>     lib/built-in.o: In function `sw842_compress':
>     oid_registry.c:(.text+0x12ddc): undefined reference to `crc32_be'
>     lib/built-in.o: In function `sw842_decompress':
>     oid_registry.c:(.text+0x137e4): undefined reference to `crc32_be'
> 
> This adds an explict 'select CRC32' statement, similar to what the other users
> of the crc32 code have. In practice, CRC32 is always enabled anyway because
> over 100 other symbols select it.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 2da572c959dd ("lib: add software 842 compression/decompression")

Patch applied.  Thanks!
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt