linux-kernel - Re: [PATCH 1/2] ne: DeviceTree support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160118.115139.619226125906732902.davem@davemloft.net>
Date:	Mon, 18 Jan 2016 11:51:39 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	andrew@...n.ch
Cc:	ysato@...rs.sourceforge.jp, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ne: DeviceTree support.

From: Andrew Lunn <andrew@...n.ch>
Date: Mon, 18 Jan 2016 16:08:34 +0100

> On Mon, Jan 18, 2016 at 04:09:40PM +0900, Yoshinori Sato wrote:
>> On Sun, 17 Jan 2016 02:22:26 +0900,
>> Andrew Lunn wrote:
>> > 
>> > On Sat, Jan 16, 2016 at 01:19:45AM +0900, Yoshinori Sato wrote:
>> > > Add basic device tree support.
>> > > 
>> > > Signed-off-by: Yoshinori Sato <ysato@...rs.sourceforge.jp>
>> > > ---
>> > >  Documentation/devicetree/bindings/net/ne2000.txt | 17 +++++++++++++++++
>> > >  drivers/net/ethernet/8390/ne.c                   | 20 +++++++++++++++++++-
>> > >  2 files changed, 36 insertions(+), 1 deletion(-)
>> > >  create mode 100644 Documentation/devicetree/bindings/net/ne2000.txt
>> > > 
>> > > diff --git a/Documentation/devicetree/bindings/net/ne2000.txt b/Documentation/devicetree/bindings/net/ne2000.txt
>> > > new file mode 100644
>> > > index 0000000..8b0dfbf
>> > > --- /dev/null
>> > > +++ b/Documentation/devicetree/bindings/net/ne2000.txt
>> > > @@ -0,0 +1,17 @@
>> > > +NE2000 compatible network controller
>> > > +
>> > > +Required properties:
>> > > +- compatible: "national,ne2000"
>> > > +- reg: base address and length of NE2000.
>> > > +- interrupts: interrupt specifier for the sole interrupt.
>> > > +- national,dcr: DCR setting value.
>> > 
>> > You say here that national,dcr is required, yet the code to read it is
>> > not returning an error if it is missing.
>> 
>> Yes. This value required. Missing error check.
>> 
>> > Also, what is DCR?
>> 
>> This is chip configuration.
>> It value depend on target design.
> 
> It needs to be described in detail what it is. Device tree bindings
> generally don't list values to be poked into registers. They describe
> something, and from that, the value to be poked into a register is
> derived.

Agreed.