lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-Id: <1453135995-27374-1-git-send-email-jaewon31.kim@gmail.com>
Date:	Tue, 19 Jan 2016 01:53:15 +0900
From:	Jaewon Kim <jaewon31.kim@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	Jaewon Kim <jaewon31.kim@...il.com>
Subject: [RFC] ratelimit: fix time interval by setting right start time

rs->begin should be initialized to the current jiffies if the begin was 0.
Even when the time interval passes, the current resetting logic sets the begin
back to 0. So next interval starts from the next call rather than from the
current resetting call. This incurrs improper suppression.

For example:
B will be suppressed althouth 3 seconds passed.
	DEFINE_RATELIMIT_STATE(limit, HZ, 1);
	__ratelimit(&limit); /* A */
	sleep(3);
	__ratelimit(&limit); /* B */

Signed-off-by: Jaewon Kim <jaewon31.kim@...il.com>
---
 lib/ratelimit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/ratelimit.c b/lib/ratelimit.c
index 40e03ea..2c5de86 100644
--- a/lib/ratelimit.c
+++ b/lib/ratelimit.c
@@ -49,7 +49,7 @@ int ___ratelimit(struct ratelimit_state *rs, const char *func)
 		if (rs->missed)
 			printk(KERN_WARNING "%s: %d callbacks suppressed\n",
 				func, rs->missed);
-		rs->begin   = 0;
+		rs->begin   = jiffies;
 		rs->printed = 0;
 		rs->missed  = 0;
 	}
-- 
1.9.1

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ