linux-kernel - Re: [PATCH v3] isdn: divamnt: use y2038-safe ktime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160117.192717.1755604764104681063.davem@davemloft.net>
Date:	Sun, 17 Jan 2016 19:27:17 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	amsfield22@...il.com
Cc:	mac@...ware.de, isdn@...ux-pingi.de, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, y2038@...ts.linaro.org
Subject: Re: [PATCH v3] isdn: divamnt: use y2038-safe ktime_get_ts64() for
 trace data timestamps

From: Alison Schofield <amsfield22@...il.com>
Date: Fri, 15 Jan 2016 08:51:25 -0800

> divamnt stores a start_time at module init and uses it to calculate
> elapsed time. The elapsed time, stored in secs and usecs, is part of
> the trace data the driver maintains for the DIVA Server ISDN cards.
> No change to the format of that time data is required.
> 
> To avoid overflow on 32-bit systems use ktime_get_ts64() to return
> the elapsed monotonic time since system boot.
> 
> This is a change from real to monotonic time. Since the driver only
> stores elapsed time, monotonic time is sufficient and more robust
> against real time clock changes. These new monotonic values can be
> more useful for debugging because they can be easily compared to
> other monotonic timestamps.
> 
> Note elaspsed time values will now start at system boot time rather
> than module load time, so they will differ slightly from previously
> reported values.
> 
> Remove declaration and init of previously unused time constants:
> start_sec, start_usec.
> 
> Signed-off-by: Alison Schofield <amsfield22@...il.com>
> Reviewed-by: Arnd Bergmann <arnd@...db.de>

Please resubmit this when the net-next tree is open again.

Thank you.