linux-kernel - Re: [PATCH v3 2/4] USB: serial: cp210x: Switch to new 16-bit register access functions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 18 Jan 2016 18:42:36 +0100
From:	Johan Hovold <johan@...nel.org>
To:	Konstantin Shkolnyy <Konstantin.Shkolnyy@...abs.com>
Cc:	Martyn Welch <martyn.welch@...labora.co.uk>,
	Konstantin Shkolnyy <konstantin.shkolnyy@...il.com>,
	"johan@...nel.org" <johan@...nel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/4] USB: serial: cp210x: Switch to new 16-bit
 register access functions.

On Thu, Jan 14, 2016 at 06:22:29PM +0000, Konstantin Shkolnyy wrote:
> > -----Original Message-----
> > From: linux-usb-owner@...r.kernel.org [mailto:linux-usb-
> > owner@...r.kernel.org] On Behalf Of Martyn Welch
> > Sent: Thursday, January 14, 2016 11:44
> > To: Konstantin Shkolnyy; johan@...nel.org
> > Cc: linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org
> > Subject: Re: [PATCH v3 2/4] USB: serial: cp210x: Switch to new 16-bit register
> > access functions.
> ...
> 
> > > @@ -697,14 +685,11 @@ static unsigned int
> > cp210x_quantise_baudrate(unsigned int baud)
> > >
> > >   static int cp210x_open(struct tty_struct *tty, struct usb_serial_port *port)
> > >   {
> > > -	int result;
> > > +	int err;

Why rename the return value? I prefer ret over err, but there's no need
to change such things for code that's already in place.

> > >
> > > -	result = cp210x_set_config_single(port, CP210X_IFC_ENABLE,
> > > -
> > 	UART_ENABLE);
> > > -	if (result) {
> > > -		dev_err(&port->dev, "%s - Unable to enable UART\n",
> > __func__);
> > > -		return result;
> > > -	}
> > > +	err = cp210x_write_u16_reg(port, CP210X_IFC_ENABLE,
> > UART_ENABLE);
> > > +	if (err)
> > > +		return err;
> > 
> > Any reason for dropping the error message?
> 
> I already print a message if the underlying usb_control_msg fails, so
> it should be covered there.

Yes, but it's an unrelated change. The previous error message was more
informative.

Thanks,
Johan