linux-kernel - Re: [PATCH] usb: fix potential integer overflow in usb_sg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1601181330450.28538-100000@netrider.rowland.org>
Date:	Mon, 18 Jan 2016 13:32:25 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Insu Yun <wuninsu@...il.com>
cc:	gregkh@...uxfoundation.org, <stefan.koch10@...il.com>,
	<kborer@...il.com>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <taesoo@...ech.edu>,
	<yeongjin.jang@...ech.edu>, <insu@...ech.edu>,
	<changwoo@...ech.edu>
Subject: Re: [PATCH] usb: fix potential integer overflow in usb_sg_init

On Mon, 18 Jan 2016, Insu Yun wrote:

> If nents value is sufficient large, e.g 0x40000000, 
> then it can overflow size in kmalloc and heap overflow happesns.
> Therefore nents value needs to be checked to prevent overflow.

I don't see why.  You seem to be assuming that failure with -EINVAL is 
better than failure with a heap overflow.  I disagree; a heap overflow 
provides more debugging information to help locate the reason for the 
underlying problem.

Alan Stern