linux-kernel - Re: [PATCH v2 02/11] lib/vsprintf: make default_dec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r3heei7v.fsf@rasmusvillemoes.dk>
Date:	Mon, 18 Jan 2016 21:38:28 +0100
From:	Rasmus Villemoes <linux@...musvillemoes.dk>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	Robert Elliott <elliott@....com>,
	Matt Fleming <matt@...eblueprint.co.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org,
	Brian Norris <computersforpeace@...il.com>,
	Hariprasad S <hariprasad@...lsio.com>
Subject: Re: [PATCH v2 02/11] lib/vsprintf: make default_dec_spec global

On Thu, Jan 14 2016, Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> There are places where default specification to print decimal numbers is used.
> Make it global and convert existing users.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  lib/test_printf.c |  5 +++--
>  lib/vsprintf.c    | 21 +++++++++------------
>  2 files changed, 12 insertions(+), 14 deletions(-)
>
> diff --git a/lib/test_printf.c b/lib/test_printf.c
> index 4f6ae60..fd985f6 100644
> --- a/lib/test_printf.c
> +++ b/lib/test_printf.c
> @@ -376,9 +376,10 @@ large_bitmap(void)
>  	if (!bits)
>  		return;
>  
> -	bitmap_set(bits, 1, 20);
> +	bitmap_set(bits, 0, 1);
> +	bitmap_set(bits, 2, 20);
>  	bitmap_set(bits, 60000, 15);
> -	test("1-20,60000-60014", "%*pbl", nbits, bits);
> +	test("0,2-21,60000-60014", "%*pbl", nbits, bits);
>  	kfree(bits);
>  }

What does this have to do with what the commit message claims this patch
is about? (I don't mind the rest of the patch, just curious why this is
included.)

Rasmus