linux-kernel - Re: [PATCH 1/1] mmzone: code cleanup for LRU stats.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160118221427.GA8657@cmpxchg.org>
Date:	Mon, 18 Jan 2016 17:14:27 -0500
From:	Johannes Weiner <hannes@...xchg.org>
To:	Maninder Singh <maninder1.s@...sung.com>
Cc:	mhocko@...nel.org, vdavydov@...tuozzo.com,
	akpm@...ux-foundation.org, mgorman@...hsingularity.net,
	vbabka@...e.cz, baiyaowei@...s.chinamobile.com,
	dan.j.williams@...el.com, tj@...nel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, cgroups@...r.kernel.org,
	ajeet.y@...sung.com, pankaj.m@...sung.com,
	Vaneet Narang <v.narang@...sung.com>
Subject: Re: [PATCH 1/1] mmzone: code cleanup for LRU stats.

On Mon, Jan 18, 2016 at 12:48:12PM +0530, Maninder Singh wrote:
> Replacing hardcoded values with enum lru_stats for LRU stats.
> 
> Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
> Signed-off-by: Vaneet Narang <v.narang@...sung.com>

I don't think the code is hard to understand, it always says 'anon' or
'file' or similar for every context where it's important to understand
what the magic array index means.

And this patch makes the lines too long and unwieldy.