linux-kernel - Re: [PATCH RESEND] android: binder: Sanity check at binder ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Jan 2016 23:33:58 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Chen Feng <puck.chen@...ilicon.com>
Cc:	arve@...roid.com, riandrews@...roid.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	yudongbin@...ilicon.com, saberlily.xia@...ilicon.com,
	suzhuangluan@...ilicon.com, kong.kongxinwei@...ilicon.com,
	xuyiping@...ilicon.com, z.liuxinliang@...ilicon.com,
	weidong2@...ilicon.com, w.f@...wei.com, puck.chen@...mail.com,
	shimingxing@...ilicon.com, oliver.fu@...ilicon.com,
	albert.lubing@...ilicon.com, chenxiang9@...wei.com,
	liuzixing@...wei.com, haojian.zhuang@...aro.org,
	zhaojunmin@...wei.com, wangjing6@...wei.com, rientjes@...gle.com,
	john.stultz@...aro.org, dan.zhao@...ilicon.com,
	dev@...ts.96boards.org, peter.panshilin@...ilicon.com,
	qijiwen@...ilicon.com, linuxarm@...wei.com
Subject: Re: [PATCH RESEND] android: binder: Sanity check at binder ioctl

On Tue, Jan 19, 2016 at 11:45:36AM +0800, Chen Feng wrote:
> When a process fork a child process, we should not allow the
> child process use the binder which opened by parent process.
> 
> But if the binder-object creater is a thread of one process who exit,
> the other thread can also use this binder-object normally.
> We can distinguish this by the member proc->tsk->mm.
> If the thread exit the tsk->mm will be NULL.
> 
> proc->tsk->mm != current->mm && proc->tsk->mm
> 
> So only allow the shared mm_struct to use the same binder-object and
> check the existence of mm_struct.
> 
> Signed-off-by: Chen Feng <puck.chen@...ilicon.com>
> Signed-off-by: Wei  Dong <weidong2@...ilicon.com>
> Signed-off-by: Junmin Zhao <zhaojunmin@...wei.com>
> Reviewed-by: Zhuangluan Su <suzhuangluan@...ilicon.com>
> ---
>  drivers/android/binder.c | 2 ++
>  1 file changed, 2 insertions(+)

Why resend?  What changed from the previous version?

greg k-h