linux-kernel - Re: [PATCH] clocksource: atmel-st: use return value from clk_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <569DF4E3.2000302@atmel.com>
Date:	Tue, 19 Jan 2016 09:33:39 +0100
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Daniel Lezcano <daniel.lezcano@...aro.org>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clocksource: atmel-st: use return value from
 clk_prepare_enable()

Le 18/01/2016 20:34, Alexandre Belloni a écrit :
> ret is used to detect an error but it was not properly updated after
> calling clk_prepare_enable() thus it made it impossible to detect an error
> when enabling the slow clock.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
> ---
>  drivers/clocksource/timer-atmel-st.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clocksource/timer-atmel-st.c b/drivers/clocksource/timer-atmel-st.c
> index 29d21d68df5a..c69070c6ad91 100644
> --- a/drivers/clocksource/timer-atmel-st.c
> +++ b/drivers/clocksource/timer-atmel-st.c
> @@ -225,7 +225,7 @@ static void __init atmel_st_timer_init(struct device_node *node)
>  	if (IS_ERR(sclk))
>  		panic(pr_fmt("Unable to get slow clock\n"));
>  
> -	clk_prepare_enable(sclk);
> +	ret = clk_prepare_enable(sclk);

Yes, sure...
Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>

Thanks!


>  	if (ret)
>  		panic(pr_fmt("Could not enable slow clock\n"));
>  
> 


-- 
Nicolas Ferre