linux-kernel - Re: [PATCH v2 05/10] tty: Fix tty_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Jan 2016 10:17:02 +0100
From:	Johan Hovold <johan@...nel.org>
To:	Peter Hurley <peter@...leysoftware.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 05/10] tty: Fix tty_init_termios() declaration

On Sat, Jan 09, 2016 at 09:13:48PM -0800, Peter Hurley wrote:
> tty_init_termios() never returns an error; re-declare as void. Remove
> unnecessary error handling from callers. Remove extern declarations
> of tty_free_termios() and free_tty_struct() and re-declare in file
> scope.
> 
> Signed-off-by: Peter Hurley <peter@...leysoftware.com>
> ---
>  drivers/tty/pty.c            | 15 +++------------
>  drivers/tty/tty_io.c         | 13 ++++---------
>  drivers/usb/serial/console.c |  6 +-----

For the usb-serial bits

Acked-by: Johan Hovold <johan@...nel.org>

Thanks,
Johan