linux-kernel - Re: [PATCH v5] acpi, apei: add Boot Error Record Table (BERT) support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CADyBb7uF=0WJVaZzfhKNLMw+f+9b2CEWw0MDfkn_s6k7LyhbEw@mail.gmail.com>
Date:	Tue, 19 Jan 2016 18:49:55 +0800
From:	Fu Wei <fu.wei@...aro.org>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Tony Luck <tony.luck@...el.com>,
	"Chen, Gong" <gong.chen@...el.com>,
	Huang Ying <ying.huang@...el.com>,
	Tomasz Nowicki <tomasz.nowicki@...aro.org>,
	Tomasz Nowicki <tn@...ihalf.com>, tbaicar@...eaurora.org,
	rruigrok@...eaurora.org,
	"Abdulhamid, Harb" <harba@....qualcomm.com>,
	G Gregory <graeme.gregory@...aro.org>,
	Al Stone <al.stone@...aro.org>,
	Hanjun Guo <hanjun.guo@...aro.org>,
	LKML <linux-kernel@...r.kernel.org>, linux-acpi@...r.kernel.org,
	Linaro ACPI Mailman List <linaro-acpi@...ts.linaro.org>,
	Jon Masters <jcm@...hat.com>,
	Mark Rutland <mark.rutland@....com>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	Rafael Wysocki <rjw@...ysocki.net>,
	"Chen, Gong" <gong.chen@...ux.intel.com>
Subject: Re: [PATCH v5] acpi, apei: add Boot Error Record Table (BERT) support

Hi Borislav,

On 19 January 2016 at 18:12, Borislav Petkov <bp@...en8.de> wrote:
> On Tue, Jan 19, 2016 at 05:34:02PM +0800, fu.wei@...aro.org wrote:
>> From: Huang Ying <ying.huang@...el.com>
>>
>> ACPI/APEI is designed to verifiy/report H/W errors, like Corrected
>> Error(CE) and Uncorrected Error(UC). It contains four tables: HEST,
>> ERST, EINJ and BERT. The first three tables have been merged for
>> a long time, but because of lacking BIOS support for BERT, the
>> support for BERT is pending until now. Recently on ARM 64 platform
>> it is has been supported. So here we come.
>>
>> Under normal circumstances, when a hardware error occurs, kernel will
>> be notified via NMI, MCE or some other method, then kernel will
>> process the error condition, report it, and recover it if possible.
>> But sometime, the situation is so bad, so that firmware may choose to
>> reset directly without notifying Linux kernel.
>>
>> Linux kernel can use the Boot Error Record Table (BERT) to get the
>> un-notified hardware errors that occurred in a previous boot. In this
>> patch, the error information is reported via printk.
>>
>> For more information about BERT, please refer to ACPI Specification
>> version 6.0, section 18.3.1:
>>   http://www.uefi.org/sites/default/files/resources/ACPI_6.0.pdf
>>
>> The following log is a BERT record after system reboot because of hitting
>> a fatal memory error:
>> BERT: Error records from previous boot:
>> [Hardware Error]: It has been corrected by h/w and requires no further action
>> [Hardware Error]: event severity: corrected
>> [Hardware Error]:  Error 0, type: recoverable
>> [Hardware Error]:   section_type: memory error
>> [Hardware Error]:   error_status: 0x0000000000000400
>> [Hardware Error]:   physical_address: 0xffffffffffffffff
>> [Hardware Error]:   card: 1 module: 2 bank: 3 row: 1 column: 2 bit_position: 5
>> [Hardware Error]:   error_type: 2, single-bit ECC
>>
>> [Tomasz Nowicki: Clear error status at the end of error handling]
>> [Tony: Applied some cleanups suggested by Fu Wei]
>> [Fu Wei: delete EXPORT_SYMBOL_GPL(bert_disable), improve the code]
>>
>> Signed-off-by: Huang Ying <ying.huang@...el.com>
>> Signed-off-by: Tomasz Nowicki <tomasz.nowicki@...aro.org>
>> Signed-off-by: Chen, Gong <gong.chen@...ux.intel.com>
>> Tested-by: Jonathan (Zhixiong) Zhang <zjzhang@...eaurora.org>
>> Signed-off-by: Tony Luck <tony.luck@...el.com>
>> Signed-off-by: Fu Wei <fu.wei@...aro.org>
>> Tested-by: Tyler Baicar <tbaicar@...eaurora.org>
>> ---
>> Changelog:
>> v5: Drop some superfluous comments.
>>     Use the introduce of BERT in ACPI Specification instead of original one
>>     at the head of bert.c.
>>     Fix typo in apei-internal.h
>>     Simplify the introduce of bert_disable.
>>
>> v4: https://lkml.org/lkml/2016/1/8/382
>>     Fix the "#undef" bug
>>     Improve the instruction of "bert_disable",
>>     Delete the useless declaration in include/acpi/apei.h.
>>
>> v3: https://lkml.org/lkml/2016/1/7/214
>>     Merge the two patches
>>     Do some improvements according to Borislav's suggestion.
>>
>> v2: https://lkml.org/lkml/2015/8/18/336
>>     Delete EXPORT_SYMBOL_GPL(bert_disable), because "bert_disable" is only
>>     used in bert.c for now.
>>     Do some code-style cleanups.
>>
>> v1: The first upstream version submitted in linux-acpi mailing list:
>>     http://www.spinics.net/lists/linux-acpi/msg57384.html
>>
>>  Documentation/kernel-parameters.txt |   3 +
>>  drivers/acpi/apei/Makefile          |   2 +-
>>  drivers/acpi/apei/apei-internal.h   |   2 +-
>>  drivers/acpi/apei/bert.c            | 150 ++++++++++++++++++++++++++++++++++++
>>  4 files changed, 155 insertions(+), 2 deletions(-)
>
> Reviewed-by: Borislav Petkov <bp@...e.de>

Great thanks for your help :-)

>
> --
> Regards/Gruss,
>     Boris.
>
> ECO tip #101: Trim your mails when you reply.



-- 
Best regards,

Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
Shanghai,China 200021