linux-kernel - Re: [RFC 00/26] perf tools: Introduce hists specific format entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160119125841.GD1324@danjae.kornet>
Date:	Tue, 19 Jan 2016 21:58:41 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [RFC 00/26] perf tools: Introduce hists specific format entries

On Mon, Jan 18, 2016 at 10:23:58AM +0100, Jiri Olsa wrote:
> hi,
> currently we have global format sort and output
> lists. This rfc patchset introduces hists object
> based format entries to allow the hist object to
> carry specific format entries.
> 
> This will allow to have distinguished hist objects
> displaying different stuff in output.

How do you manage hists objects to have different hpp lists?  Will you
provide an option to users?  Or is it specific to some tools like
c2c?


> 
> Also available in:
>   git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
>   perf/hists_fmt
> 
> thanks for comments,
> jirka
> 
> 
> ---
> Jiri Olsa (26):
>       perf tools: Factor output_resort from hists__output_resort
>       perf tools: Introduce perf_evsel__output_resort function
>       perf tools: Add _idx fields into struct perf_hpp_fmt
>       perf tools: Use struct perf_hpp_fmt::idx in perf_hpp__reset_width
>       perf tools: Add equal method to perf_hpp_fmt struct
>       perf tools: Add hpp__equal callback function
>       perf tools: Make hpp setup function generic
>       perf report: Move ui initialization ahead of sort setup
>       perf tools: Allocate output sort field
>       perf tools: Remove perf_hpp__column_(disable|enable)
>       perf tools: Properly release format fields
>       perf tools: Separate sort fields parsing into setup_sort_list function
>       perf tools: Separate output fields parsing into setup_output_list function
>       perf tools: Introduce struct perf_hpp_list
>       perf tools: Introduce perf_hpp_list__init function
>       perf tools: Add perf_hpp_list register helpers
>       perf tools: Pass perf_hpp_list all the way through setup_sort_list
>       perf tools: Pass perf_hpp_list all the way through setup_output_list
>       perf tools: Introduce perf_hpp_list__for_each_format macro
>       perf tools: Introduce perf_hpp_list__for_each_format_safe macro
>       perf tools: Introduce perf_hpp_list__for_each_sort_list macro
>       perf tools: Introduce perf_hpp_list__for_each_sort_list_safe macro
>       perf tools: Add struct perf_hpp_list argument to helper functions
>       perf tools: Add hpp_list into struct hists object
>       perf tools: Introduce hists__for_each_format macro
>       perf tools: Introduce hists__for_each_sort_list macro
> 
>  tools/perf/builtin-annotate.c     |   2 +-
>  tools/perf/builtin-report.c       |  20 ++++-----
>  tools/perf/builtin-top.c          |  10 +++--
>  tools/perf/tests/hists_cumulate.c |   2 +-
>  tools/perf/tests/hists_filter.c   |   2 +-
>  tools/perf/tests/hists_output.c   |  10 ++---
>  tools/perf/ui/browsers/hists.c    |   8 ++--
>  tools/perf/ui/gtk/hists.c         |   6 +--
>  tools/perf/ui/hist.c              | 170 +++++++++++++++++++++++++++++++++++++----------------------------------
>  tools/perf/ui/stdio/hist.c        |  10 ++---
>  tools/perf/util/hist.c            |  47 ++++++++++++++------
>  tools/perf/util/hist.h            |  65 ++++++++++++++++++++--------
>  tools/perf/util/sort.c            | 231 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------
>  13 files changed, 359 insertions(+), 224 deletions(-)