linux-kernel - Re: [PATCH 2/4] sched: Consolidate nohz CPU load update code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160119131333.GD6344@twins.programming.kicks-ass.net>
Date:	Tue, 19 Jan 2016 14:13:33 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Byungchul Park <byungchul.park@....com>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Chris Metcalf <cmetcalf@...hip.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Luiz Capitulino <lcapitulino@...hat.com>,
	Christoph Lameter <cl@...ux.com>,
	"Paul E . McKenney" <paulmck@...ux.vnet.ibm.com>,
	Mike Galbraith <efault@....de>, Rik van Riel <riel@...hat.com>
Subject: Re: [PATCH 2/4] sched: Consolidate nohz CPU load update code

On Thu, Jan 14, 2016 at 02:18:40PM +0900, Byungchul Park wrote:
> > +	__update_cpu_load_nohz(this_rq, READ_ONCE(jiffies), 0, 0);
> 
> This question is not directly related to this patch but I am just
> curious about... Should we use READ_ONCE on jiffies which is already
> volatile type?

I'd say so, if only because I forever forget that jiffies is declared
volatile and READ_ONCE() makes the intent explicit.