lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Jan 2016 15:21:24 +0200 From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> To: One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>, Peter Hung <hpeter@...il.com> Cc: Paul Gortmaker <paul.gortmaker@...driver.com>, gregkh@...uxfoundation.org, jslaby@...e.com, heikki.krogerus@...ux.intel.com, peter@...leysoftware.com, soeren.grunewald@...y.de, udknight@...il.com, adam.lee@...onical.com, arnd@...db.de, yamada.masahiro@...ionext.com, mans@...sr.com, scottwood@...escale.com, paul.burton@...tec.com, matthias.bgg@...il.com, manabian@...il.com, peter.ujfalusi@...com, linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org, peter_hong@...tek.com.tw, Peter Hung <hpeter+linux_kernel@...il.com> Subject: Re: [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file On Tue, 2016-01-19 at 12:33 +0000, One Thousand Gnomes wrote: > > The architecture of 8250_pci.c is good for PCIE device with 8250 > > compatible serial ports. We want to implement all functions of > > F81504/508/512, but it'll make 8250_pci.c bloated and complex if we > > implement GPIOLIB in 8250_pci.c > > Your device is multi-function. Create an MFD driver for it. Make the > 8250 driver bind to the MFD, and provide your own baud rate methods > within the standard 8250 layer Ouch, somehow I missed this one! Peter, Alan's suggestion is really worth to try. > > Implement the GPIO lines in a GPIO driver that also binds to the MFD > and > lives in drivers/gpio > > All the needed pieces already exist to implement it cleanly this way > without duplicating a ton of code. > > Alan -- Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Intel Finland Oy
Powered by blists - more mailing lists