linux-kernel - Re: [RFC PATCH v1] refining the rpm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9438969.iYZ3h3fHzb@vostro.rjw.lan>
Date:	Tue, 19 Jan 2016 14:49:15 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Zhaoyang Huang <zhaoyang.huang@...aro.org>
Cc:	zhaoyang.huang@...eadtrum.com, pavel@....cz,
	linux-kernel@...r.kernel.org, len.brown@...el.com,
	gregkh@...uxfoundation.org, linux-pm@...r.kernel.org
Subject: Re: [RFC PATCH v1] refining the rpm_suspend function

On Tuesday, January 19, 2016 05:14:18 PM Zhaoyang Huang wrote:
> There are too many branch path within he original rpm_suspend funciton,which make
> the code a little bit hard for understanding and debugging.Just try to split the
> function into some small one to eliminate the goto and make one optimization for
> avoiding transfering from wait to auto when irq_safe flag set
> 
> Signed-off-by: Zhaoyang Huang <zhaoyang.huang@...eadtrum.com>

First off, please don't mix cleanups with optimizations.

Second, I don't really think that the changes you're making improve things
from the readability/debugging viewpoint.

Thanks,
Rafael