linux-kernel - Re: [PATCH RESEND] omap_hdq: fix usecount handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <59381453221508@web14g.yandex.ru>
Date:	Tue, 19 Jan 2016 19:38:28 +0300
From:	Evgeniy Polyakov <zbr@...emap.net>
To:	Andreas Kemnade <andreas@...nade.info>,
	"hns@...delico.com" <hns@...delico.com>,
	Fabian Frederick <fabf@...net.be>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>
Subject: Re: [PATCH RESEND] omap_hdq: fix usecount handling

Hi Andreas

>From w1 perspective this doesn't break things :)
Greg, please pull it into your tree if no one objects.

Acked-by: Evgeniy Polyakov <zbr@...emap.net>

16.01.2016, 15:48, "Andreas Kemnade" <andreas@...nade.info>:
> hdq_usecount was set to zero after a successful read, so
> omap_hdq_put could not properly free resources which leads
> e.g. to increasing usecounts in lsmod output
>
> Signed-off-by: Andreas Kemnade <andreas@...nade.info>
> ---
>  drivers/w1/masters/omap_hdq.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
> index 0e2f43b..a2eec97 100644
> --- a/drivers/w1/masters/omap_hdq.c
> +++ b/drivers/w1/masters/omap_hdq.c
> @@ -618,7 +618,6 @@ static u8 omap_w1_read_byte(void *_hdq)
>
>          hdq_disable_interrupt(hdq_data, OMAP_HDQ_CTRL_STATUS,
>                                ~OMAP_HDQ_CTRL_STATUS_INTERRUPTMASK);
> - hdq_data->hdq_usecount = 0;
>
>          /* Write followed by a read, release the module */
>          if (hdq_data->init_trans) {
> --
> 2.1.4