linux-kernel - Re: [LINUX PATCH 2/5] Documentation: mmc: Updated the binding doc for Arasan SDHCI.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <569E8865.1030504@xilinx.com>
Date:	Tue, 19 Jan 2016 20:03:01 +0100
From:	Michal Simek <michal.simek@...inx.com>
To:	Rob Herring <robh@...nel.org>,
	P L Sai Krishna <lakshmi.sai.krishna.potthuri@...inx.com>
CC:	Michal Simek <michal.simek@...inx.com>,
	Soren Brinkmann <soren.brinkmann@...inx.com>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Kevin Hao <haokexin@...il.com>,
	Emil Lenchak <emill@...inx.com>,
	Tobias Klauser <tklauser@...tanz.ch>,
	Sudeep Holla <Sudeep.Holla@....com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Jisheng Zhang <jszhang@...vell.com>,
	"Ivan T. Ivanov" <ivan.ivanov@...aro.org>,
	Scott Branden <sbranden@...adcom.com>,
	Vincent Yang <vincent.yang.fujitsu@...il.com>,
	Haibo Chen <haibo.chen@...escale.com>,
	Marek Vasut <marex@...x.de>,
	"ludovic.desroches@...el.com" <ludovic.desroches@...el.com>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	"Suman Tripathi" <stripathi@....com>,
	Shawn Lin <shawn.lin@...k-chips.com>,
	<devicetree@...r.kernel.org>, Harini Katakam <harinik@...inx.com>,
	<linux-mmc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	P L Sai Krishna <lakshmis@...inx.com>,
	Anirudha Sarangi <anirudh@...inx.com>,
	"Punnaiah Choudary Kalluri" <punnaia@...inx.com>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [LINUX PATCH 2/5] Documentation: mmc: Updated the binding doc for
 Arasan SDHCI.

On 19.1.2016 18:19, Rob Herring wrote:
> On Tue, Jan 19, 2016 at 07:47:32PM +0530, P L Sai Krishna wrote:
>> This patch adds broken-tuning property to the binding
>> doc for Arasan SDHCI.
>>
>> Signed-off-by: P L Sai Krishna <lakshmis@...inx.com>
>> ---
>>  Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>> index da541c3..2088d9f 100644
>> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>> @@ -17,6 +17,10 @@ Required Properties:
>>    - interrupt-parent: Phandle for the interrupt controller that services
>>  		      interrupts for this device.
>>  
>> +Optional Properties:
>> +  - broken-tuning: Indicates tuning broken in Silicon 1.0 of
>> +			  Zynq Ultrascale+ MPSoC.
>> +
> 
> Make this a standard property.
> 
> Or use the compatible string to determine this. Si errata is exactly 
> what they are for.

I still think that having interface for runtime Silicon version
detection in generic way is much better than using compatible strings
for certain silicon version.
The same board revisions can have different silicon versions.

Asking secure monitor for this information and based on that setup
quirks for this case would be preferred solution.
I want to spend some time to share information about silicon via soc bus
to user space and there should be similar way for sharing this
information inside the kernel.

Thanks,
Michal