linux-kernel - Re: [PATCH v7 5/5] ARM: dts: rockchip: add support mipi panel tv080wum-nl0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1649978.zzK0Pex4sR@phil>
Date:	Tue, 19 Jan 2016 20:26:04 +0100
From:	Heiko Stuebner <heiko@...ech.de>
To:	Chris Zhong <zyw@...k-chips.com>
Cc:	linux-rockchip@...ts.infradead.org, mark.yao@...k-chips.com,
	treding@...dia.com, Russell King <linux@....linux.org.uk>,
	devicetree@...r.kernel.org, Kumar Gala <galak@...eaurora.org>,
	linux-kernel@...r.kernel.org,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v7 5/5] ARM: dts: rockchip: add support mipi panel tv080wum-nl0

Hi Chris,

Am Mittwoch, 6. Januar 2016, 12:03:57 schrieb Chris Zhong:
> This tv080wum-nl0 panel is a mipi panel, it can use in MIPI_TX socket
> of rk3288 evb board.
> 
> Signed-off-by: Chris Zhong <zyw@...k-chips.com>

[...]

> diff --git a/arch/arm/boot/dts/rk3288-evb-act8846.dts
> b/arch/arm/boot/dts/rk3288-evb-act8846.dts index e662147..7d5475b 100644
> --- a/arch/arm/boot/dts/rk3288-evb-act8846.dts
> +++ b/arch/arm/boot/dts/rk3288-evb-act8846.dts
> @@ -50,6 +50,8 @@
>  		gpio = <&gpio7 3 GPIO_ACTIVE_HIGH>;
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&lcd_en>;
> +		regulator-always-on;
> +		regulator-boot-on;

Is this only needed for the panel itself and can you try to get the panel 
supplies set up correctly instead in that case please?


>  		regulator-name = "vcc_lcd";
>  		vin-supply = <&vcc_io>;
>  	};
> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi
> b/arch/arm/boot/dts/rk3288-evb.dtsi index 4faabdb..0c91858 100644
> --- a/arch/arm/boot/dts/rk3288-evb.dtsi
> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi
> @@ -47,7 +47,7 @@
>  		reg = <0x0 0x80000000>;
>  	};
> 
> -	backlight {
> +	backlight: backlight {
>  		compatible = "pwm-backlight";
>  		brightness-levels = <
>  			  0   1   2   3   4   5   6   7
> @@ -183,6 +183,16 @@
>  	status = "okay";
>  };
> 
> +&mipi_dsi {
> +	status = "okay";
> +	panel {
> +		compatible ="boe,tv080wum-nl0";
> +		reg = <0>;
> +		backlight = <&backlight>;
> +		status = "okay";

in the evb-schematics I see, vcc_lcd as supply for the panel.

So I'd think the panel node here should have a
	power-supply = <&vcc_lcd>;
instead of having the always-on above?


Thanks
Heiko

> +	};
> +};
> +
>  &sdmmc {
>  	bus-width = <4>;
>  	cap-mmc-highspeed;